Skip to content

[CI] Split mteb test from Language Models Test #24634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2025
Merged

[CI] Split mteb test from Language Models Test #24634

merged 3 commits into from
Sep 11, 2025

Conversation

noooop
Copy link
Contributor

@noooop noooop commented Sep 11, 2025 •
edited by github-actions bot
Loading

Purpose

refactoring following #22992

Split mteb test from Language Models Test to Language Models Test (MTEB) ~30 minutes

cc @DarkLight1337 @maxdebayser

Test Plan

pytest -v -s models/language/pooling_mteb_test

Test Result

keep ci green

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@noooop
Copy link
Contributor Author

noooop commented Sep 11, 2025

Conflicts with #24632

@mergify mergify bot added ci/build qwen Related to Qwen models labels Sep 11, 2025
@noooop noooop marked this pull request as ready for review September 11, 2025 09:05
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 11, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 11, 2025 09:11
@noooop
Copy link
Contributor Author

noooop commented Sep 11, 2025

@DarkLight1337

Please do not forget to test the new Language Models Test (MTEB)

@vllm-bot vllm-bot merged commit fd1ce98 into vllm-project:main Sep 11, 2025
74 of 78 checks passed
@noooop noooop deleted the split_mteb branch September 12, 2025 16:32
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
@noooop @skyloevil
[CI] Split mteb test from Language Models Test (vllm-project#24634)
f4fd61c 
Signed-off-by: wang.yuqi <[email protected]>
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
@noooop @dsxsteven
[CI] Split mteb test from Language Models Test (vllm-project#24634)
0d40089 
Signed-off-by: wang.yuqi <[email protected]>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@noooop @FeiDaLI
[CI] Split mteb test from Language Models Test (vllm-project#24634)
f2c7c6d 
Signed-off-by: wang.yuqi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

Assignees
No one assigned
Labels
ci/build qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noooop @DarkLight1337 @vllm-bot