Add PodVMInfo type and method #3850
Open
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support to PodVMInfo VMODL APIs under HostRuntimeInfo which includes hasPodVM and podVMOverheadInfo properties. In addition this patch also adds UpdatePodVMProperty method under HostSystem. The PodVMInfo property and method will be updated by ESXi host and will be consumed by DRS to determine PodVM placement. The change also includes a unit test that tests the setting of PodVMInfo property. Testing: - make test: === RUN TestPodVMInfo --- PASS: TestPodVMInfo (0.69s) - Verified UpdatePodVMProperty() method from ESXi: --- PASS: TestSetOverheadVMODLProperty (0.20s) PASS
akutz
requested changes
Sep 3, 2025
| PropertyPath: propertyPath, | ||
| } | ||
|
|
||
| if propertyPath == "podVMOverheadInfo" { |
There was a problem hiding this comment.
This seems like a good use for a switch statement instead of so many if/elses.
| return fmt.Errorf("unsupported propertyPath: %s", propertyPath) | ||
| } | ||
|
|
||
| _, err := methods.UpdatePodVMProperty(ctx, h.c, &req) |
There was a problem hiding this comment.
Rewrite as:
_, err := methods.UpdatePodVMProperty(ctx, h.c, &req)
return err| @@ -44786,6 +44786,8 @@ type HostRuntimeInfo struct { | |||
| PartialMaintenanceMode []HostPartialMaintenanceModeRuntimeInfo `xml:"partialMaintenanceMode,omitempty" json:"partialMaintenanceMode,omitempty" vim:"8.0.3.0"` | |||
| // Host persistent state encryption information. | |||
| StateEncryption *HostRuntimeInfoStateEncryptionInfo `xml:"stateEncryption,omitempty" json:"stateEncryption,omitempty" vim:"7.0.3.0"` | |||
| // PodVM related info for a host | |||
| PodVMInfo *HostRuntimeInfoPodVMInfo `xml:"podVMInfo,omitempty" json:"podVMInfo,omitempty" vim:"9.0.0.0"` | |||
There was a problem hiding this comment.
Hmm, you have updated a generated type. I'm not sure we can support this.
There was a problem hiding this comment.
This type is already part of HostRuntime VMODL (on main/9.1). Does that mean when HostRuntime is regenerated this property (PodVMInfo) will be re-added ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds support to PodVMInfo VMODL APIs under HostRuntimeInfo which includes hasPodVM and podVMOverheadInfo properties. In addition this patch also adds UpdatePodVMProperty method under HostSystem. The PodVMInfo property and method will be updated by ESXi host and will be consumed by DRS to determine PodVM placement. The change also includes a unit test that tests the setting of PodVMInfo property.
Note: PodVMOverheadInfo that is currently exposed as part of HostCapability will be removed
as a follow-up change, once existing consumers have moved away from it.
Closes: VMKUW-2865
How Has This Been Tested?
=== RUN TestPodVMInfo
--- PASS: TestPodVMInfo (0.69s)
--- PASS: TestSetOverheadVMODLProperty (0.20s)
PASS