vcsim: fix snapshot state handling #3853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a snapshot is created with memory, the snapshot's state should reflect the VM's power state at the time of snapshot creation, and when snapshot is create without memory, the state should be powered off. The simulator was not setting this state correctly, leading to inconsistencies. Signed-off-by: Nabarun Pal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a snapshot is created with memory, the snapshot's state should reflect
the VM's power state at the time of snapshot creation, and when snapshot
is create without memory, the state should be powered off. The simulator
was not setting this state correctly, leading to inconsistencies.
Closes: #(issue-number)
How Has This Been Tested?
Unit tests are added in simulator/virtual_machine_test.go
Manually tested by using the changes against vmware-tanzu/vm-operator#1146
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.