Skip to content

Conversation

baiwusanyu-c
Copy link
Member

close: #6752

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
sfc-playground ⬜️ Ignored (Inspect) Apr 6, 2023 0:44am

Copy link

github-actions bot commented Jan 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 91.3 kB (+1.84 kB) 34.8 kB (+810 B) 31.4 kB (+678 B)
vue.global.prod.js 148 kB (+1.84 kB) 54 kB (+731 B) 48.2 kB (+634 B)

Usages

Name Size Gzip Brotli
createApp 51.7 kB (+1.91 kB) 20.3 kB (+812 B) 18.5 kB (+699 B)
createSSRApp 55.1 kB (+1.91 kB) 21.7 kB (+827 B) 19.8 kB (+783 B)
defineCustomElement 54 kB (+1.91 kB) 21.1 kB (+817 B) 19.2 kB (+689 B)
overall 65.1 kB (+1.84 kB) 25.2 kB (+799 B) 22.9 kB (+682 B)

@skirtles-code
Copy link
Contributor

I don't think this is the right fix.

Rather than adding a warning, it should ignore the comment in production, same as during dev.

It's possible that #6238 or #7387 will already fix this problem, though I think those PRs still need more work before they can be merged.

@yyx990803 yyx990803 closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

DEV_ROOT_FRAGMENT patchFlag is set despite compilerOptions.comments = true
4 participants