Skip to content

Calculate query complexity with fragments correctly independent of order #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Calculate query complexity with fragments correctly independent of order #1668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4999c9b
Calculate query complexity with fragments correctly independent of order
spawnia Jan 21, 2025
599f711
Apply php-cs-fixer changes
spawnia Jan 21, 2025
6b6910e
Merge branch 'master' into query-complexity-fragment-order
spawnia Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/Validator/QueryComplexityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ public function testFragmentQueries(): void
$this->assertDocumentValidators($query, 2, 3);
}

/** @dataProvider fragmentQueriesOnRootProvider */
public function testFragmentQueriesOnRoot(string $query): void
{
$this->assertDocumentValidators($query, 12, 13);
}

/** @return iterable<array<string>> */
public function fragmentQueriesOnRootProvider(): iterable
{
yield ['fragment humanFragment on QueryRoot { human { dogs { name } } } query { ...humanFragment }']; // success example
yield ['query { ...humanFragment } fragment humanFragment on QueryRoot { human { dogs { name } } }']; // failing example, changed order see https://github.com/webonyx/graphql-php/issues/785
}

public function testAliasesQueries(): void
{
$query = 'query MyQuery { thomas: human(name: "Thomas") { firstName } jeremy: human(name: "Jeremy") { firstName } }';
Expand Down
Loading