-
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
apiAPI integration and external services (Issues/PRs)API integration and external services (Issues/PRs)
Description
Issue Description
There is a naming conflict between two interfaces that serve different purposes:
- src/types/discord.ts - Contains for environment configuration (DISCORD_BOT_TOKEN, CLIENT_ID, POSTGRES_URL, etc.)
- src/sdk/bots-brain/BotsStore.ts - Contains for bot configuration storage (key, value, expiresAt)
Impact
This creates import confusion and potential naming collisions when both interfaces are used in the same file.
Suggested Solution
Rename the BotsStore interface from BotConfig
to ConfigEntry
(or similar) while keeping the method names unchanged (setBotConfig
, getBotConfig
, deleteBotConfig
).
Code Change Required
// In src/sdk/bots-brain/BotsStore.ts
export interface ConfigEntry {
key: string;
value: unknown;
expiresAt?: string;
}
References
- Original PR: 🚀 release: v1.0.0 #62
- Comment thread: 🚀 release: v1.0.0 #62 (comment)
- Requested by: @warengonzaga
Metadata
Metadata
Assignees
Labels
apiAPI integration and external services (Issues/PRs)API integration and external services (Issues/PRs)