feat: add note to suggest use CookieStore instead of document.cookie #11668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chanran
force-pushed
the
feat/add-note-suggest-use-cookiestore
branch
from
1bf0ed6 to
2505013
Compare
Chanran
force-pushed
the
feat/add-note-suggest-use-cookiestore
branch
from
2505013 to
bef184c
Compare
myakura
reviewed
Sep 16, 2025
myakura
reviewed
Sep 16, 2025
Chanran
force-pushed
the
feat/add-note-suggest-use-cookiestore
branch
from
9f9fc90 to
7eba4f8
Compare
zcorpan
requested changes
Sep 17, 2025
zcorpan
reviewed
Sep 18, 2025
|
I see you have signed as an individual. Since Bytedance makes a web browser I think you should sign as an entity. |
zcorpan
approved these changes
Sep 19, 2025
|
Actually this can be merged without signing since it's a trivial contribution. Thanks! |
|
@zcorpan Thanks! We will try to contribute to WHATWG as an entity and contribute more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #11658, synchronous document.cookie API calls are a major source of jank, and the asynchronous CookieStore API can be used as a replacement. Therefore, we add a note to suggest to use CookieStore API instead of document.cookie.
/dom.html ( diff )
/references.html ( diff )