Skip to content

Overall component improvements #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2017
Merged

Overall component improvements #10

merged 2 commits into from
Jun 9, 2017

Conversation

cristijora
Copy link
Contributor

This is quite a big PR but I couldn't do it otherwise:
Here is the list of what this PR introduces:

  • Build step with webpack (vue-cli basically)
  • Unit tests setup and sample unit test
  • Dev environment setup and a very basic demo (available with npm run dev)
  • Js bundle extraction so the component can be used in html files directly See fiddle: https://jsfiddle.net/CristiJ/z11fe07p/2079/ (available with npm run bundle)
  • webpack bundle stats (a stats.json file is generated each time a bundle is created so you can analyse dependencies and bundle size)
  • eslint (disabled now)

cristijora added 2 commits June 7, 2017 09:07
@cristijora
Add build step
e9d7e21 
Add sample demo (npm run dev)
Add sample unit test
Add webpack config for browser bundling so the component will be available via script tag in html
@cristijora
Remove vuetable js file
f6f7860
@xaksis
Copy link
Owner

xaksis commented Jun 8, 2017

woah! this looks great. I'll play around with this tomorrow and report back. Thanks!

@xaksis xaksis merged commit dce3884 into xaksis:master Jun 9, 2017
MosheL pushed a commit to MosheL/vue-good-table that referenced this pull request Dec 8, 2024
@borisflesch
Merge pull request xaksis#10 from tbrains/patch-1
f9396d1 
Grouped Header Row Checkbox issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaksis xaksis xaksis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristijora @xaksis