Automate MauiCompat build, Update MAUI Preview 11 #1775
Conversation
VladislavAntonyuk
changed the title
VladislavAntonyuk
changed the title
VladislavAntonyuk
requested review from
TheCodeTraveler,
pictos and
jfversluis
There was a problem hiding this comment.
Instead of creating a MauiCompatExists variable and ensuring it is True before attempting to do steps like Build Xamarin.CommunityToolkit.MauiCompat.csproj, should we instead fail the build?
I.e. What if we remove condition: eq (variables['MauiCompatExists'], True) on all of the MauiCompat steps and let the build fail when the MauiCompat steps don't work?
I think letting the build fail will ensure future PRs won't break MauiCompat. Am I understanding this correctly?
|
I thought MauiCompat remains optional if the script fails, but seems like it checks only for path exist, this validation can be removed |
| } | ||
| }" | ||
|
|
||
| sed -i '' 's/public class/using Xamarin.CommunityToolkit.MauiCompat; public class/g' ./src/CommunityToolkit/Xamarin.CommunityToolkit.MauiCompat/Effects/IconTintColor/IconTintColorEffectRouter.ios.cs |
There was a problem hiding this comment.
automate MauiColor extensions (ToAndroid, ToUIColor)
|
|
||
| # Log | ||
|
|
||
| sed -i '' 's/using System;/using System;using Microsoft.Extensions.Logging;/g' ./src/CommunityToolkit/Xamarin.CommunityToolkit.MauiCompat/**/**.cs |
There was a problem hiding this comment.
src/CommunityToolkit/Xamarin.CommunityToolkit/Core/FileMediaSourceConverter.shared.cs
Show resolved
Hide resolved
src/CommunityToolkit/Xamarin.CommunityToolkit/Views/MediaElement/UriTypeConverter.shared.cs
Show resolved
Hide resolved
|
I will rework pipeline logic a bit. We need to skip script if MauiCompat exists ( for branch like 1.3.0-MauiCompat) |
VladislavAntonyuk
force-pushed
the
maui-compat-automation
branch
from
df56d9b to
af315e8
Compare
|
Thanks Vlad!! |
Description of Bug
Automate MauiCompat generation, Update MauiCompat to preview 11
PR Checklist
approved