This repository was archived by the owner on May 1, 2024. It is now read-only.
Fixed naming convention of CaptureModeProperty #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted a comment from
|
@jsuarezruiz Hi should I do something or is it ok? Sorry....first time ;-) |
|
@redeaglekiller this is fine! And a good catch. So sorry this bug was in there :( Thank you for finding and fixing it! |
jfversluis
approved these changes
Jan 19, 2021
|
@jfversluis Thank you guys for this awesome Toolkit. I will report other things as I find them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changed PropertyName to fix naming convention.
-Can't test the MACOS compile, but it should work.
-Tests are ok on Windows and working on an Android device
-No samples necessary in my opinion.
-Documentation Update not necessary
Bugs Fixed
API Changes
None
Behavioral Changes
-Intellisense should work now
-MVVM supported with naming convention on CameraView
PR Checklist