Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Fix LocalizationResourceManager.Init(ResourceManager, CultureInfo) doesn't trigger property changed #915

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Fix LocalizationResourceManager.Init(ResourceManager, CultureInfo) doesn't trigger property changed #915

merged 5 commits into from
Feb 16, 2021

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Feb 16, 2021 •
edited
Loading

Description of Change

Currently Init overload with CultureInfo sets CurrentCulture, but PropertyChanged event doesn't get triggered.
Fixed that.

Bugs Fixed

Fixes: #916

API Changes

None

Behavioral Changes

When LocalizationResourceManager.Init(ResourceManager, CultureInfo) is called PropertyChanged is triggered.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@maxkoshevoi maxkoshevoi changed the base branch from main to develop February 16, 2021 18:43
@pictos
Copy link
Contributor

pictos commented Feb 16, 2021

@maxkoshevoi can you please create an issue and link it here?

@maxkoshevoi maxkoshevoi changed the base branch from develop to main February 16, 2021 19:33
@maxkoshevoi
Copy link
Contributor Author

@maxkoshevoi can you please create an issue and link it here?

Done

AndreiMisiukevich
AndreiMisiukevich approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@AndreiMisiukevich AndreiMisiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pictos pictos added a/i18n 🌐 bug Something isn't working. Breaky break. labels Feb 16, 2021
@pictos pictos merged commit 12ee0d0 into xamarin:main Feb 16, 2021
@maxkoshevoi maxkoshevoi deleted the lrm-init branch February 16, 2021 20:46
inforithmics pushed a commit to inforithmics/XamarinCommunityToolkit that referenced this pull request Feb 19, 2021
@maxkoshevoi @inforithmics
Fix LocalizationResourceManager.Init(ResourceManager, CultureInfo) do…
81c8cf4 
…esn't trigger property changed (xamarin#915)

* Update LocalizationResourceManager.shared.cs

* Update LocalizationResourceManagerTests.cs

* Fix build errors

* Fix build errors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@AndreiMisiukevich AndreiMisiukevich AndreiMisiukevich approved these changes

@pictos pictos pictos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a/i18n 🌐 bug Something isn't working. Breaky break.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] LocalizationResourceManager.Init(ResourceManager, CultureInfo) doesn't trigger property changed
3 participants
@maxkoshevoi @pictos @AndreiMisiukevich