[DM] Add estimates for erasing local disks in disks.DeleteDisk #4390
+245
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for contributing! |
Rattysed
added
ok-to-test
github-actions
bot
removed
the
ok-to-test
BarkovBG
reviewed
Sep 22, 2025
cloud/disk_manager/internal/pkg/performance/config/config.proto
Outdated
Show resolved
Hide resolved
BarkovBG
reviewed
Sep 22, 2025
cloud/disk_manager/internal/pkg/services/disks/delete_disk_task.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/services/disks/delete_disk_task.go
Outdated
Show resolved
Hide resolved
gy2411
reviewed
Sep 22, 2025
cloud/disk_manager/internal/pkg/services/disks/delete_disk_task_test.go
Outdated
Show resolved
Hide resolved
cloud/disk_manager/internal/pkg/services/disks/delete_disk_task.go
Outdated
Show resolved
Hide resolved
jkuradobery
reviewed
Sep 23, 2025
jkuradobery
previously approved these changes
Sep 23, 2025
Rattysed
reviewed
Sep 23, 2025
cloud/disk_manager/internal/pkg/services/disks/delete_disk_task.go
Outdated
Show resolved
Hide resolved
BarkovBG
reviewed
Sep 24, 2025
BarkovBG
approved these changes
Sep 24, 2025
jkuradobery
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3738
Add estimated times for
disks.DeleteDisk. In most cases, the task completes instantly. But on deleting local disks (local-hdd or local-ssd) blockstore needs to erase it, so it takes some time that I am estimating in this PR.Proposing setting the bandwidth for SDD local disks to 500 MiB/s and HDD local disks to 100 MiB/s.