This repository was archived by the owner on Mar 26, 2018. It is now read-only.
feat(app): remove minsafe options #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, there's just one comment left in the |
|
I left that one in there since its actually talking about ngmin and not the minsafe templates. Confusing wording so open to suggestions on improving it. |
|
You should fix the tests ;) Hard to accept PRs when it's failing. (general, not concerning this particular PR though). |
|
they are fixed. i didnt rebase the fixes though. it had to do with the generator upgrade. im rewriting the tests for this generator anyway |
|
rebased and the tests pass |
Remove the minsafe templates, documentation and options from the generator. Closes #452 BREAKING CHANGE: Removes the --minsafe from the generator. See the readme for more information about this change
|
updated the gruntfile comment as well |
|
I guess it should be fine. If we come up with a better explanation later, we can always change it. Let's get this sucker in. |
passy
added a commit
that referenced
this pull request
Jan 27, 2014
feat(app): remove minsafe options
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the minsafe templates, documentation and options from the
generator.
Closes #452
BREAKING CHANGE: Removes the --minsafe from the generator. See the
readme for more information about this change