Skip to content

Conversation

maxbrunsfeld
Copy link
Collaborator

This reverts commit bf5ed6d.

We believe this may be breaking some users whose shell initialization scripts change the working directory.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 3, 2025
@maxbrunsfeld maxbrunsfeld added the run-bundling Configures PR to run the bundle step label Sep 3, 2025
@maxbrunsfeld maxbrunsfeld force-pushed the revert-login-shell-for-ssh-commands branch from 7358290 to b826cd0 Compare September 3, 2025 03:39
@ConradIrwin
Copy link
Member

Thanks for figuring this out!

@maxbrunsfeld maxbrunsfeld merged commit bb13228 into main Sep 3, 2025
21 checks passed
@maxbrunsfeld maxbrunsfeld deleted the revert-login-shell-for-ssh-commands branch September 3, 2025 21:24
@Aeolun
Copy link

Aeolun commented Sep 4, 2025

Jup, this was definitely breaking my my remote dev. Though to be fair, that was because my .profile spewed out a bunch of garbage. I think it'd probably be helpful if zed looks for something that looks like the output of uname if it's going to use it while also loading the profile.

@achimnol
Copy link

achimnol commented Sep 4, 2025

I also bumped with this issue, as sh cannot execute eval $(pyenv init --path) commands.
If we want to keep the original commit's intention, it should use the user's default login shell instead of the vanilla sh.

notpeter pushed a commit that referenced this pull request Sep 4, 2025
This reverts commit bf5ed6d.

We believe this may be breaking some users whose shell initialization
scripts change the working directory.

Release Notes:

- N/A
notpeter pushed a commit that referenced this pull request Sep 4, 2025
This reverts commit bf5ed6d.

We believe this may be breaking some users whose shell initialization
scripts change the working directory.

Release Notes:

- N/A
@ConradIrwin
Copy link
Member

I think there's probably two things:

  • When we're running things like uname, we want the minimal stuff happening.
  • When we run shell commands within Zed, we should be putting you in a login shell.

I think there's some middle ground which I don't understand yet, which is some internal Zed commands being run. That might need some more thought, but it sounds like in some cases you need some stuff that's currently happening in sh that should be happening in a different shell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement run-bundling Configures PR to run the bundle step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants