17 chart language

[pjhoberman]

See notes in #17. This is in draft for now.

[quinn-dougherty]

@pjhoberman i'm gonna do the auto-update from here sooner rather than later, fetch it down please hope it doesn't cause conflict

[quinn-dougherty]

nvm it said there's a merge conflict already

[pjhoberman]

@quinn-dougherty rebased and re-pushed. It's in draft mode while I wait for feedback though

[sam-writer]

Just to check - there is a big formatting change as well, that is intentional? I see @mdbecker 's commit running black (is that part of CI/CD?) as part of this PR... just trying to understand that.

About the real content of this PR - I like the way it is done. I have one code style thought, but nothing blocking. It seems like the only purpose of the second param, def chart_descriptions(chart, census=False) is

    if census:
        cols = [col + " Census" for col in cols]

it might be more extensible to just make the second parameter the word we want to add, eg def chart_descriptions(chart, suffix="") and do something like if suffix != "": cols = [col + " " + suffix for col in cols]

But like I said, not blocking

[quinn-dougherty]

black is not in ci/cd yet #193

[pjhoberman]

@sam-qordoba The formatting updates are from the rebase. I'm not sure how to avoid pulling those commits in when I rebase - any thoughts?

I like the suffix idea. It's a bit fragile in that it's also related to the column name in the df. Trying to balance DRY. I can update that though!

[sam-writer]

@pjhoberman yeah I mean, it is still brittle so it might not matter. Just a thought.

@quinn-dougherty or @pjhoberman or @mdbecker - is this the way that @mdbecker 's formatting changes are coming into the dev branch? or are his changes in another branch also? I am fine with either, just curious

[sam-writer]

LGTM