Updates to number input step, min val, and types #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2020 23:01
* Updated min value and step for most number inputs. * Updated format for float inputs to display as float instead of as int. Cleanup * Removed unused imports
|
This looks good. I really like the float inputs. doubling_time float is useful. I assume we're stuck with the less useful +/- steps for some of the controls, and there might not be a way to suppress the +/- buttons. I don't know what cypress is doing, otherwise I'd approve. |
|
Ops says that all cypress tests are failing right now, so the PR isn't breaking anything that we can tell. |
jlubken
approved these changes
Mar 27, 2020
|
I haven't looked into the +/- controls. I'll do that today. Cypress is failing since the step for regional population changed the post-click value isn't what is expected. I'll fix that today, too. |
added 3 commits
March 27, 2020 10:29
jlubken
changed the title
This was
linked to
issues
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes in
./src/penn_chime/Fixes for issue 269
presentation.pyUpdated min value and step for most number inputs.presentation.pyUpdated format for float inputs to display as float instead of as int.defaults.pyChange Constants type for doubling_time and relative_contact_rate from int to floatsettings.pyChange default doubling_time from int to floatCleanup
presentation.pyFixes #269