Skip to content

Conversation

ecsmyth
Copy link
Collaborator

@ecsmyth ecsmyth commented Mar 28, 2020

Updates a few number input parameters to bring them inline with the Streamlit version as of PR #283.

@ecsmyth ecsmyth added the dash for 2.0 label Mar 28, 2020
@ecsmyth ecsmyth added this to the Move to Dash milestone Mar 28, 2020
@ckoerber
Copy link
Collaborator

Thanks for the PR. Seems fine and does what it promises (e.g.,"error" rendered form inputs are now with white border).

One thing one may consider here is increasing the step value for float forms because it also affects the up and down arrows shift amounts (and FLOAT_INPUT_MIN = 0.001 takes many clicks). It might be more user friendly to set both the minimal value and the shift value to a sensible small number for each input. Does someone have a strong opinion on this?

@ecsmyth
Copy link
Collaborator Author

ecsmyth commented Mar 28, 2020

With Dash, we could set step to "any" which will still allow input of precise numbers but will result in the arrows stepping by 1. This wasn't possible in the Streamlit version.

@ckoerber
Copy link
Collaborator

That sounds like a good idea.

…sing ui buttons and more precise entry via keyboard
Copy link
Collaborator

@ckoerber ckoerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and solves the issue. Thanks for the update.

@ckoerber ckoerber merged commit 386ff95 into dash Mar 29, 2020
@ckoerber ckoerber deleted the dash_pr_283_parity branch March 29, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dash for 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants