-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[App] Moved app.py to root dir for lightning init app <app_name>
template
#13853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lexierule
merged 7 commits into
master
from
fix-template-app-py-should-be-in-app-directory
Aug 17, 2022
Merged
[App] Moved app.py to root dir for lightning init app <app_name>
template
#13853
lexierule
merged 7 commits into
master
from
fix-template-app-py-should-be-in-app-directory
Aug 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Aug 3, 2022
Adding an entry in the changelog would be nice if you can :) |
for more information, see https://pre-commit.ci
manskx
approved these changes
Aug 4, 2022
tchaton
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
approved these changes
Aug 8, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently when You init a new app using
lightning init app <app_name>
theapp.py
is in the module directory which impacts running app with--cloud
flag (as therequirements.txt
is in different dir.Here, we move
app.py
up to achieve the following templated structure:Fixes issues with running with
--cloud
flag. And standardises the folder structure.Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda