Skip to content

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 27, 2022

What does this PR do?

The https://github.com/Lightning-AI/lightning/pull/15105/files#r1004923337 was missed.

cc @Borda @Borda @justusschock

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.9 milestone Oct 27, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 27, 2022
@carmocca
Copy link
Contributor

Until we fix the tests added with #15309 or we merge #15347, this is blocked

@awaelchli awaelchli marked this pull request as draft October 27, 2022 11:35
@awaelchli awaelchli self-assigned this Oct 31, 2022
@carmocca carmocca marked this pull request as ready for review November 9, 2022 13:13
@carmocca carmocca enabled auto-merge (squash) November 9, 2022 13:14
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2022
@carmocca carmocca merged commit 3dcb85a into master Nov 9, 2022
@carmocca carmocca deleted the tests/undo-standalone2 branch November 9, 2022 14:03
Borda pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 3dcb85a)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit 3dcb85a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants