Skip to content

Undo marking tests that don't need it as standalone #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Undo marking tests that don't need it as standalone #15355

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
481cfc3
undo marking tests that don't need it as standalone
awaelchli Oct 27, 2022
5fe1c88
Merge branch 'master' into tests/undo-standalone2
carmocca Nov 9, 2022
f50abfb
unused import
awaelchli Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/tests_pytorch/loops/test_training_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ def validation_step(self, *args):
assert model.validation_called_at == (0, 5)


@RunIf(standalone=True)
def test_fit_loop_done_log_messages(caplog):
fit_loop = FitLoop(max_epochs=1)
trainer = Mock(spec=Trainer)
Expand Down Expand Up @@ -212,7 +211,6 @@ def training_step_end(self, outputs):
(4, 10, 4, True, True, True),
],
)
@RunIf(standalone=True)
def test_should_stop_early_stopping_conditions_met(
caplog, min_epochs, min_steps, current_epoch, early_stop, fit_loop_done, raise_debug_msg
):
Expand Down