Skip to content

Fix action_name usage in XLAProfiler #15886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2022
Merged

Fix action_name usage in XLAProfiler #15886

merged 6 commits into from
Dec 9, 2022

Conversation

Liyang90
Copy link
Contributor

@Liyang90 Liyang90 commented Dec 2, 2022 •
edited by awaelchli
Loading

What does this PR do?

Fixes #15885

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 2, 2022
@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit profiler labels Dec 5, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Dec 5, 2022
@awaelchli
Copy link
Contributor

@Liyang90 do you have the capacity to add a unit test as well?

@awaelchli awaelchli added the community This PR is from the community label Dec 5, 2022
@Liyang90
Copy link
Contributor Author

Liyang90 commented Dec 5, 2022

Hi @awaelchli , I don't think a unit test would catch this, since it is related to how the profiler is used in the Trainer and elsewhere.

awaelchli
awaelchli reviewed Dec 5, 2022
View reviewed changes
@awaelchli awaelchli self-assigned this Dec 5, 2022
@awaelchli awaelchli added the bug Something isn't working label Dec 6, 2022
@mergify mergify bot added the has conflicts label Dec 9, 2022
@mergify mergify bot removed the has conflicts label Dec 9, 2022
@Borda Borda enabled auto-merge (squash) December 9, 2022 10:49
@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@Borda Borda merged commit c748f82 into Lightning-AI:master Dec 9, 2022
Borda pushed a commit that referenced this pull request Dec 9, 2022
@Liyang90 @Borda
Fix action_name usage in XLAProfiler (#15886)
d1509ad 
* Fix `action_name` usage in `XLAProfiler`
* add changelog
* Update src/pytorch_ligh
* Update xla.py

Co-authored-by: awaelchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit c748f82)
lantiga added a commit that referenced this pull request Dec 9, 2022
@Borda @lantiga
@tchaton @akihironitta @Liyang90 @justusschock @ethanwharris
Releasing/1.8.4.post (#15988)
6a39743 
* Apply dynamo to training_step, validation_step, test_step, predict_step (#15957)

* Apply dynamo to training_step, validation_step, test_step, predict_step

* Add entry to CHANGELOG.md

(cherry picked from commit edc9986)

* [App] Resolve run installation (#15974)

(cherry picked from commit dd83587)

* App: Move AutoScaler dependency to extra requirements (#15971)

* Make autoscaler dependency optional
* update chglog
* dont directly import aiohttp

(cherry picked from commit 346e936)

# Conflicts:
#	requirements/app/base.txt
#	src/lightning_app/CHANGELOG.md

* Avoid using the same port number for autoscaler works (#15966)

* dont hardcode port in python server
* add another chglog

(cherry picked from commit a72d268)

* Fix `action_name` usage in `XLAProfiler` (#15886)

* Fix `action_name` usage in `XLAProfiler`
* add changelog
* Update src/pytorch_ligh
* Update xla.py

Co-authored-by: awaelchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit c748f82)

* Fix multinode cloud component (#15965)

* fix multinode cloud component
* add tests

(cherry picked from commit d21b899)

* ci: update signaling (#15981)

* ci: update signaling
* config

(cherry picked from commit e56e7f1)

* Fix cloudcomputes registration for structures (#15964)

* fix cloudcomputes
* updates cloudcompute registration
* changelog

(cherry picked from commit 90a4c02)

* Document running dev lightning on the cloud (#15962)

* document running dev lightning on the cloud

* document running dev lightning on the cloud

* Update .github/CONTRIBUTING.md

Co-authored-by: Noha Alon <[email protected]>

* document running dev lightning on the cloud

* git clone & pip install -e

* Update .github/CONTRIBUTING.md

Co-authored-by: Jirka Borovec <[email protected]>

Co-authored-by: Noha Alon <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit cfd00d3)

* [App] Install exact version whn upgrading and not when testing (#15984)

* [App] Install exact version whn upgrading and not when testing
* Update CHANGELOG.md

Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit 1657ea8)

* releasing 1.8.4.post0

Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
@Liyang90 Liyang90 deleted the Liyang90-patch-1 branch January 31, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@awaelchli awaelchli

Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package profiler ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

XLAProfiler on TPU not working
3 participants
@Liyang90 @awaelchli @Borda