Skip to content

Fix action_name usage in XLAProfiler #15886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Fix action_name usage in XLAProfiler #15886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12c74f1
Fix `action_name` usage in `XLAProfiler`
Liyang90 Dec 2, 2022
ecf0c25
add changelog
awaelchli Dec 5, 2022
4a393cd
Update src/pytorch_lightning/profilers/xla.py
Liyang90 Dec 6, 2022
3505261
Update xla.py
Liyang90 Dec 6, 2022
4eaa7ad
Merge branch 'master' into Liyang90-patch-1
awaelchli Dec 7, 2022
af2a290
Merge branch 'master' into Liyang90-patch-1
Borda Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/pytorch_lightning/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Enhanced `reduce_boolean_decision` to accommodate `any`-analogous semantics expected by the `EarlyStopping` callback ([#15253](https://github.com/Lightning-AI/lightning/pull/15253))


- Fixed the `XLAProfiler` not recording anything due to mismatching of action names ([#15885](https://github.com/Lightning-AI/lightning/pull/15885))


## [1.8.4] - 2022-12-08

### Changed
Expand Down
6 changes: 4 additions & 2 deletions src/pytorch_lightning/profilers/xla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,14 @@ def __init__(self, port: int = 9012) -> None:
def start(self, action_name: str) -> None:
import torch_xla.debug.profiler as xp

if action_name in self.RECORD_FUNCTIONS:
# The action name is formatted as '[TYPE]{class name}.{hook name}'
# Example: [LightningModule]BoringModel.training_step
if action_name.split(".")[-1] in self.RECORD_FUNCTIONS:
if not self._start_trace:
self.server = xp.start_server(self.port)
self._start_trace = True

if action_name in self.STEP_FUNCTIONS:
if action_name.split(".")[-1] in self.STEP_FUNCTIONS:
step = self._get_step_num(action_name)
recording = xp.StepTrace(action_name, step_num=step)
else:
Expand Down