Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lightning/fabric/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
### Fixed

- Fixed with adding a missing device id for pytorch 2.8 ([#21105](https://github.com/Lightning-AI/pytorch-lightning/pull/21105))
- Respect `verbose=False` in `seed_everything` when no seed is provided


---
Expand Down
3 changes: 2 additions & 1 deletion src/lightning/fabric/utilities/seed.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def seed_everything(seed: Optional[int] = None, workers: bool = False, verbose:
env_seed = os.environ.get("PL_GLOBAL_SEED")
if env_seed is None:
seed = 0
rank_zero_warn(f"No seed found, seed set to {seed}")
if verbose:
rank_zero_warn(f"No seed found, seed set to {seed}")
else:
try:
seed = int(env_seed)
Expand Down
8 changes: 8 additions & 0 deletions tests/tests_fabric/utilities/test_seed.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ def test_seed_everything_accepts_valid_seed_from_env():
assert seed_everything() == 17


@mock.patch.dict(os.environ, {}, clear=True)
def test_seed_everything_non_verbose_no_warning():
"""Ensure that no warning is emitted when verbose is False and no seed is provided."""
with warnings.catch_warnings(record=True) as caught:
seed_everything(verbose=False)
assert caught == []


def test_reset_seed_no_op():
"""Test that the reset_seed function is a no-op when seed_everything() was not used."""
assert "PL_GLOBAL_SEED" not in os.environ
Expand Down
Loading