Skip to content

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Feb 26, 2023

🐛 Fix Quick Lissy93 /FIX/most-used-last-used-counter → Lissy93/dashy Commits: 3 | Files Changed: 3 | Additions: 0

Category: Bugfix

Overview

  • 🐛 4fc3abf - Fix most-used and last-used counter
    • The issue was caused by item ID being undefined, as this.id should have been this.item.id
  • 🚨 c3749c6 - Fix lint warning in clock component (use single quotes)
  • 🚨 743232e - Fix lint warning in Mvg widget (use 2-space indentation)

Issue Number #1056 #1033

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • [] (If a new config option is added) Attribute is outlined in the schema and documented
  • [] (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • [] Bumps version, if new feature added

@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Feb 26, 2023
@Lissy93 Lissy93 self-assigned this Feb 26, 2023
@netlify
Copy link

netlify bot commented Feb 26, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 4fc3abf
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63fb6a385515150008e02671
😎 Deploy Preview https://deploy-preview-1123--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Feb 26, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit d5b70c1 into master Feb 26, 2023
@Lissy93 Lissy93 deleted the FIX/most-used-last-used-counter branch February 26, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant