Skip to content

[FIX] Counter for most-used + last-used, and lint warns #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2023
Merged

[FIX] Counter for most-used + last-used, and lint warns #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3749c6
🚨 Fix lint warn, single quotes in clock
Lissy93 Feb 26, 2023
743232e
🚨 Fix lint warn, indentation in Mvg widget
Lissy93 Feb 26, 2023
4fc3abf
🐛 Fix most-used / last-used storage (#1056, #1033)
Lissy93 Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Widgets/Clock.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default {
return !this.options.hideSeconds;
},
use12Hour() {
if (typeof this.options.use12Hour === "boolean") return this.options.use12Hour;
if (typeof this.options.use12Hour === 'boolean') return this.options.use12Hour;
// this is the default, it gets computed by the DateTimeFormat implementation
return Intl.DateTimeFormat(this.timeFormat, { timeZone: this.timeZone, hour: 'numeric' }).resolvedOptions().hour12 ?? false;
},
Expand Down
6 changes: 3 additions & 3 deletions src/components/Widgets/Mvg.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
:class="{cancelled: departure.cancelled}">{{ departure.destination }}</div>
<span class="delay"
:class="{'has-delay': departure.realtimeDepartureTime > departure.plannedDepartureTime}"
>{{ Math.max(0,
>{{ Math.max(0,
(departure.realtimeDepartureTime - departure.plannedDepartureTime)/60000) }}</span>
<span class="occupancy"
:class="'occupancy-' + departure.occupancy"
Expand Down Expand Up @@ -131,9 +131,9 @@ export default {
filter_results(value) {
if (!this.options.filters) return true;
let useEntry = (
(!this.options.filters.line)
(!this.options.filters.line)
|| this.ensure_array(this.options.filters.line).includes(value.label)
);
);
useEntry = useEntry
&& (
(!this.options.filters.product)
Expand Down
4 changes: 2 additions & 2 deletions src/mixins/ItemMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ export default {
this.$emit('itemClicked');
// Update the most/ last used ledger, for smart-sorting
if (!this.appConfig.disableSmartSort) {
this.incrementMostUsedCount(this.id);
this.incrementLastUsedCount(this.id);
this.incrementMostUsedCount(this.item.id);
this.incrementLastUsedCount(this.item.id);
}
},
/* Open item, using specified method */
Expand Down