Skip to content

feat(user_settings): enhance profile edit functionality #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(user_settings): enhance profile edit functionality #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c3b865
feat(user_settings): enhance profile edit functionality
youngbeom-shin Sep 11, 2025
fa8f9f6
feat(user_settings): enhance profile edit functionality
Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 122 additions & 1 deletion frontend/src/assets/stylesheets/element-plus/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,127 @@
box-shadow: var(--shadow-xs);
}

/* btn-outline */
.btn-outline {
background-color: var(--Base-White);
border: 1px solid var(--Gray-300);
color: var(--Gray-700);
}

.btn-outline:hover {
background-color: var(--Gray-50);
border: 1px solid var(--Gray-300);
color: var(--Gray-800);
}

.btn-outline:focus {
box-shadow: 0px 1px 2px 0px rgba(16, 24, 40, 0.05), 0px 0px 0px 4px rgba(152, 162, 179, 0.14);
}

.btn-outline[disabled] {
background-color: var(--Base-White);
color: var(--Gray-400);
border: 1px solid var(--Gray-200);
}

/* btn-outline-primary */
.btn-outline-primary {
background-color: var(--Base-White);
border: 1px solid var(--Brand-300);
color: var(--Brand-700);
}

.btn-outline-primary:hover {
background-color: var(--Brand-50);
border: 1px solid var(--Brand-300);
color: var(--Brand-800);
}

.btn-outline-primary:focus {
box-shadow: 0px 1px 2px 0px rgba(16, 24, 40, 0.05), 0px 0px 0px 4px rgba(77, 106, 214, 0.24);
}

.btn-outline-primary[disabled] {
background-color: var(--Base-White);
color: var(--Gray-400);
border: 1px solid var(--Gray-200);
}

/* btn-outline-danger */
.btn-outline-danger {
background-color: var(--Base-White);
border: 1px solid var(--Error-300);
color: var(--Error-700);
}

.btn-outline-danger:hover {
background-color: var(--Error-50);
border: 1px solid var(--Error-300);
color: var(--Error-800);
}

.btn-outline-danger:focus {
box-shadow: 0px 1px 2px 0px rgba(16, 24, 40, 0.05), 0px 0px 0px 4px rgba(240, 68, 56, 0.24);
}

.btn-outline-danger[disabled] {
background-color: var(--Base-White);
color: var(--Gray-400);
border: 1px solid var(--Gray-200);
}

/* btn-ghost */
.btn-ghost {
background-color: transparent;
border: 1px solid transparent;
color: var(--Gray-600);
box-shadow: none;
}

.btn-ghost:hover {
background-color: var(--Gray-50);
border: 1px solid transparent;
color: var(--Gray-700);
}

.btn-ghost[disabled] {
color: var(--Gray-400);
}

/* btn-ghost-primary */
.btn-ghost-primary {
background-color: transparent;
border: 1px solid transparent;
color: var(--Brand-700);
}

.btn-ghost-primary:hover {
background-color: var(--Brand-50);
border: 1px solid transparent;
color: var(--Brand-800);
}

.btn-ghost-primary[disabled] {
color: var(--Gray-400);
}

/* btn-ghost-danger */
.btn-ghost-danger {
background-color: transparent;
border: 1px solid transparent;
color: var(--Error-700);
}

.btn-ghost-danger:hover {
background-color: var(--Error-50);
border: 1px solid transparent;
color: var(--Error-800);
}

.btn-ghost-danger[disabled] {
color: var(--Gray-400);
}

/* btn-tertiary-gray */
.btn-tertiary-gray {
color: var(--Gray-600);
Expand Down Expand Up @@ -193,6 +314,7 @@
/* sm size button */
.btn-primary.btn-sm,
.btn-danger.btn-sm,
.btn-outline-danger.btn-sm,
.btn-secondary-gray.btn-sm,
.btn-secondary-color.btn-sm,
.btn-tertiary-gray.btn-sm,
Expand Down Expand Up @@ -356,4 +478,3 @@
text-align: center;
justify-content: center;
}

4 changes: 2 additions & 2 deletions frontend/src/components/__tests__/user_settings/ProfileEdit.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('ProfileEdit.vue', () => {
const clickSpy = vi.spyOn(wrapper.vm.fileInput, 'click')

// Find and click the upload avatar button
await wrapper.find('.btn.btn-primary.btn-sm').trigger('click')
await wrapper.find('.btn.btn-secondary-gray.btn-sm').trigger('click')

expect(clickSpy).toHaveBeenCalled()
})
Expand All @@ -168,7 +168,7 @@ describe('ProfileEdit.vue', () => {

wrapper.vm.profileData.avatar.value = 'https://example.com/avatar.jpg'

await wrapper.find('.btn-secondary-gray.btn-sm').trigger('click')
await wrapper.find('.btn.btn-outline-danger.btn-sm').trigger('click')

await wrapper.vm.$nextTick()

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/user_settings/Menu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<div class="z-20 bg-white border-b border-gray-100">
<div class="z-20 bg-white border-gray-100">
<div class="sticky top-14 pt-6 w-72 rounded-md mx-6 md:w-full md:mx-0">
<div
@click="clickProfile"
Expand Down
Loading