Skip to content

Conversation

WYB27
Copy link
Collaborator

@WYB27 WYB27 commented Sep 5, 2025

Description

接入Glm4.5模型
已完成:

  • 模型组网已跑通
  • 精度已对齐(1e-2级别)
  • tp已接入(全部linear)
  • sft lora 多卡训练可进行
  • pp已接入

todo:
补充单测

Copy link

paddle-bot bot commented Sep 5, 2025

Thanks for your contribution!

@lugimzzz
Copy link
Collaborator

lugimzzz commented Sep 5, 2025

要仔细验证一下TP & TP+SP收敛精度是否一致

@lugimzzz
Copy link
Collaborator

lugimzzz commented Sep 8, 2025

1.验证打开TP+SP是否有问题
2.验证sdpa & flashmask是否有问题
3.验证一下模型保存和热启是否有问题

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 18.73684% with 386 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@caee94f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/glm4_moe/modeling.py 18.48% 344 Missing ⚠️
...ddleformers/transformers/glm4_moe/configuration.py 15.38% 33 Missing ⚠️
paddleformers/nn/pp_model.py 30.00% 7 Missing ⚠️
paddleformers/trl/llm_utils.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (18.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2554   +/-   ##
==========================================
  Coverage           ?   28.68%           
==========================================
  Files              ?      308           
  Lines              ?    53764           
  Branches           ?        0           
==========================================
  Hits               ?    15420           
  Misses             ?    38344           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@nepeplwu nepeplwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nepeplwu nepeplwu merged commit c370cdb into PaddlePaddle:develop Sep 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants