-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Update dag list default sorting to alphabetically #50600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dag list default sorting to alphabetically #50600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, the default order is last_run_start_date
. Which I think is expected because you want to see dags that recently run first.
Why do you think dag_id
makes more sense by default ?
I don't have a strong opinion, but using |
We can go for
|
Dissmissing my review since there might be a better place for this fix as Pierre mentioned
Yep, |
Co-authored-by: pierrejeambrun <[email protected]>
fb846e7
to
1a22f67
Compare
Thanks for pointing out. I've updated to use |
Is it perhaps better to make it configurable somewhere what you want to sort by? Different people might have different preferences of what to sort by. |
It should be topological, falling back to the order it is added to the dag. There is an existing bug for this |
Sorry, totally misread this and thought it was about tasks |
Make sense to make a config. I would try to implement it. Thanks! |
Different people may want different sort order in the same instance too though. Maybe the sort choice should be sticky when you navigate away and back, instead of a global config. |
Yeah, that makes sense. We do that for a bunch of stuff already with graph view, etc. We can do the same thing here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can add follow up PR to persist the sorting preference in the localstorage.
Sure, I would open following PR for that. Thanks. |
(cherry picked from commit ae9ae04) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]> Co-authored-by: pierrejeambrun <[email protected]>
…0652) (cherry picked from commit ae9ae04) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]> Co-authored-by: pierrejeambrun <[email protected]>
…0652) (cherry picked from commit ae9ae04) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]> Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>
Why
Currently the default dag list sorting isn’t by dag_display_name which is not really straightforward
How
Update the default sorting to alphabetically.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.