Skip to content

Update dag list default sorting to alphabetically #50600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Update dag list default sorting to alphabetically #50600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions airflow-core/src/airflow/ui/src/pages/Connections/Connections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,7 @@ const columns: Array<ColumnDef<ConnectionResponse>> = [
];

export const Connections = () => {
const { setTableURLState, tableURLState } = useTableURLState({
sorting: [{ desc: false, id: "connection_id" }],
});
const { setTableURLState, tableURLState } = useTableURLState();
const [searchParams, setSearchParams] = useSearchParams();
const { NAME_PATTERN: NAME_PATTERN_PARAM }: SearchParamsKeysType = SearchParamsKeys;
const [connectionIdPattern, setConnectionIdPattern] = useState(
Expand All @@ -97,7 +95,7 @@ export const Connections = () => {
useConnectionTypeMeta(); // Pre-fetch connection type metadata
const { pagination, sorting } = tableURLState;
const [sort] = sorting;
const orderBy = sort ? `${sort.desc ? "-" : ""}${sort.id}` : "-connection_id";
const orderBy = sort ? `${sort.desc ? "-" : ""}${sort.id}` : "connection_id";
const { data, error, isFetching, isLoading } = useConnectionServiceGetConnections({
connectionIdPattern: connectionIdPattern ?? undefined,
limit: pagination.pageSize,
Expand Down
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const columns: Array<ColumnDef<DAGWithLatestDagRunsResponse>> = [
},
},
{
accessorKey: "dag_id",
accessorKey: "dag_display_name",
cell: ({ row: { original } }) => (
<Link asChild color="fg.info" fontWeight="bold">
<RouterLink to={`/dags/${original.dag_id}`}>{original.dag_display_name}</RouterLink>
Expand Down Expand Up @@ -180,7 +180,7 @@ export const DagsList = () => {
);

const [sort] = sorting;
const orderBy = sort ? `${sort.desc ? "-" : ""}${sort.id}` : "-last_run_start_date";
const orderBy = sort ? `${sort.desc ? "-" : ""}${sort.id}` : "dag_display_name";

const handleSearchChange = (value: string) => {
if (value) {
Expand Down