Always show backfill button but enable it only on dags with schedule. #50969
Conversation
tirkarthi
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
pierrejeambrun
added
the
backport-to-v3-0-test
…th schedule. (#50969) (cherry picked from commit f8c8200) Co-authored-by: Karthikeyan Singaravelan <[email protected]>
Backport successfully created: v3-0-test
|
…th schedule. (#50969) (#50970) (cherry picked from commit f8c8200) Co-authored-by: Karthikeyan Singaravelan <[email protected]>
|
Mhm, I just see this change and... actually I dis-like it. I undrstand that people seeking for (the new cool feature to backfill as advertised) and can not see it if no schedule. BUT: The new UI uses a lot more whitespace and when using the trigger form as modal a lot of screen space is occupied for a selection that is actually not a benefit if you just want to trigger. Could we make this somehow configurable? In my view it just clutters the UI when no backfill possible. |
|
Later on the UI will also handle the permissions, which means that this button will most likely disappear again if users do not have permissions to create backfill. Maybe that could be a workaround => Don't give user backfill permissions if you don't want them to see the disabled button. (But that's 3.1.0+ unfortunately). |
…th schedule. (#50969) (#50970) (cherry picked from commit f8c8200) Co-authored-by: Karthikeyan Singaravelan <[email protected]>
Closes #50904