Skip to content

Always show backfill button but enable it only on dags with schedule. #50969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Always show backfill button but enable it only on dags with schedule. #50969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { Heading, VStack, HStack, Spinner, Center, Text } from "@chakra-ui/react
import React, { useState } from "react";

import { useDagServiceGetDag } from "openapi/queries";
import { Dialog } from "src/components/ui";
import { Dialog, Tooltip } from "src/components/ui";
import { RadioCardItem, RadioCardRoot } from "src/components/ui/RadioCard";

import RunBackfillForm from "../DagActions/RunBackfillForm";
Expand Down Expand Up @@ -93,7 +93,7 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
</Center>
) : (
<>
{dag && hasSchedule ? (
{dag ? (
<RadioCardRoot
my={4}
onChange={(event) => {
Expand All @@ -107,11 +107,14 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
label="Single Run"
value={RunMode.SINGLE}
/>
<RadioCardItem
description="Run this DAG for a range of dates"
label="Backfill"
value={RunMode.BACKFILL}
/>
<Tooltip content="Backfill requires a schedule" disabled={hasSchedule}>
<RadioCardItem
description="Run this DAG for a range of dates"
disabled={!hasSchedule}
label="Backfill"
value={RunMode.BACKFILL}
/>
</Tooltip>
</HStack>
</RadioCardRoot>
) : undefined}
Expand Down