Fix the misalignment of gantt view progress bars (#55061) #55291
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yimingpeng
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
guan404ming
approved these changes
Sep 6, 2025
| @@ -185,9 +187,9 @@ export const Gantt = ({ limit }: Props) => { | |||
| minBarLength: MIN_BAR_WIDTH, | |||
| }, | |||
| ], | |||
| labels: [], | |||
| labels: chartLabels, | |||
There was a problem hiding this comment.
Suggested change
| labels: chartLabels, | |
| labels: flatNodes.map((node) => node.id), |
I think it would be better and more clear in this way.
There was a problem hiding this comment.
agree, I was thinking to get the labels specifically memoized would be performant but could be trivial, thanks and making the updates now.
| }), | ||
| [data], | ||
| [data, chartLabels], |
There was a problem hiding this comment.
Suggested change
| [data, chartLabels], | |
| [data, flatNodes], |
We could add |
aha, copy that, thanks for all the suggestions, :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a fix for the gannt view progress bar misalignment with dag versioning (#55061).
closes: #55061
hello @guan404ming, could you please review when you have a chance? Thank you!
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.