Skip to content

Fix the misalignment of gantt view progress bars (#55061) #55291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix the misalignment of gantt view progress bars (#55061) #55291

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8aa806
Add label population from current running tasks to fix gantt view mis…
yimingpeng Sep 5, 2025
752c1d6
Merge branch 'apache:main' into to-fix-gantt-progress-bar-misalignmen…
yimingpeng Sep 7, 2025
b6d08a7
Improve the clarity based on the review comments
yimingpeng Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions airflow-core/src/airflow/ui/src/layouts/Details/Gantt/Gantt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ export const Gantt = ({ limit }: Props) => {
.filter((item) => item !== undefined);
}, [flatNodes, gridTiSummaries, taskInstancesData, selectedTimezone, isLoading, runId]);

const chartLabels = useMemo(() => flatNodes.map((node) => node.id), [flatNodes]);

const chartData = useMemo(
() => ({
datasets: [
Expand All @@ -185,9 +187,9 @@ export const Gantt = ({ limit }: Props) => {
minBarLength: MIN_BAR_WIDTH,
},
],
labels: [],
labels: chartLabels,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: chartLabels,
labels: flatNodes.map((node) => node.id),

I think it would be better and more clear in this way.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, I was thinking to get the labels specifically memoized would be performant but could be trivial, thanks and making the updates now.

}),
[data],
[data, chartLabels],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[data, chartLabels],
[data, flatNodes],

);

const fixedHeight = flatNodes.length * CHART_ROW_HEIGHT + CHART_PADDING;
Expand Down