Skip to content

KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] #20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] #20465

wants to merge 3 commits into from
+4 −8

Conversation

shashankhs11
Copy link
Contributor

@shashankhs11 shashankhs11 commented Sep 3, 2025 •
edited by lucasbru
Loading

clean up SmokeTestDriverIntegrationTest

Reviewers: Lucas Brutschy [email protected]

@github-actions github-actions bot added triage PRs from the community streams tests Test fixes (including flaky tests) small Small PRs labels Sep 3, 2025
@shashankhs11 shashankhs11 mentioned this pull request Sep 3, 2025
Open
@lucasbru lucasbru self-assigned this Sep 8, 2025
@lucasbru lucasbru requested a review from Copilot September 8, 2025 07:19
Copilot
Copilot AI reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the SmokeTestDriverIntegrationTest by removing the state updater configuration parameter from the parameterized test. The change simplifies the test by removing the stateUpdaterEnabled parameter and its corresponding test cases, reducing the test matrix from 6 combinations to 4.

  • Removes stateUpdaterEnabled parameter from the parameterized test method
  • Updates the @CsvSource annotation to remove test cases that included the state updater parameter
  • Removes the STATE_UPDATER_ENABLED configuration from the test properties

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

...tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
Comment on lines 118 to 121
public void shouldWorkWithRebalance(
final boolean stateUpdaterEnabled,
final boolean processingThreadsEnabled,
final boolean streamsProtocolEnabled
) throws InterruptedException {
Copy link
Preview

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method signature and parameter documentation should be updated to reflect the removal of the stateUpdaterEnabled parameter. Consider updating any existing JavaDoc comments to accurately describe the current test parameters.

Copilot uses AI. Check for mistakes.

lucasbru
lucasbru approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasbru lucasbru changed the title KAFKA-19666: Clean up integration tests related to state-updater KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lucasbru lucasbru lucasbru approved these changes

Assignees

@lucasbru lucasbru

Labels
ci-approved small Small PRs streams tests Test fixes (including flaky tests) triage PRs from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shashankhs11 @lucasbru @chia7712