Skip to content

KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] #20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

KAFKA-19666: Remove old restoration codepath from SmokeTestDriverIntegrationTest [3/N] #20465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f9dbc2
clean up SmokeTestDriverIntegrationTest
shashankhs11 Sep 3, 2025
d15540b
Merge branch 'trunk' into KAFKA-19666-3
shashankhs11 Sep 4, 2025
2cb74c2
fix merging
shashankhs11 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...ts/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,12 @@ SmokeTestDriver.VerificationResult result() {
// (1) 10 min timeout, (2) 30 tries of polling without getting any data
@ParameterizedTest
@CsvSource({
"false, false, true",
"true, false, true",
"false, false, false",
"true, false, false",
"true, true, true",
"true, true, false"
"false, true",
"false, false",
"true, true",
"true, false"
})
public void shouldWorkWithRebalance(
final boolean stateUpdaterEnabled,
final boolean processingThreadsEnabled,
final boolean streamsProtocolEnabled
) throws InterruptedException {
Comment on lines 118 to 121
Copy link
Preview

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method signature and parameter documentation should be updated to reflect the removal of the stateUpdaterEnabled parameter. Consider updating any existing JavaDoc comments to accurately describe the current test parameters.

Copilot uses AI. Check for mistakes.

Expand All @@ -143,7 +140,6 @@ public void shouldWorkWithRebalance(
final String appId = safeUniqueTestName(testInfo);
props.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers);
props.put(StreamsConfig.APPLICATION_ID_CONFIG, appId);
props.put(InternalConfig.STATE_UPDATER_ENABLED, stateUpdaterEnabled);
props.put(InternalConfig.PROCESSING_THREADS_ENABLED, processingThreadsEnabled);
if (streamsProtocolEnabled) {
props.put(StreamsConfig.GROUP_PROTOCOL_CONFIG, GroupProtocol.STREAMS.name().toLowerCase(Locale.getDefault()));
Expand Down