Skip to content

fix(test) - Patch more boto sessions for certain scenarios #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix(test) - Patch more boto sessions for certain scenarios #234

merged 1 commit into from
Jan 19, 2023

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 7, 2022

Issue #, if available:

Description of changes:

  • Patch more boto sessions for certain scenarios

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mmaeng
Copy link
Contributor

mmaeng commented Dec 21, 2022 •
edited
Loading

Closing #239 in favor of this.

This also closes #219 and removes the need for environment variables or credentials file to be populated for unittests to succeed.

@kddejong kddejong merged commit 1e0b1a9 into aws-cloudformation:master Jan 19, 2023
@kddejong kddejong deleted the chore/test/patch/session branch January 19, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ericzbeard ericzbeard ericzbeard approved these changes

@mmaeng mmaeng mmaeng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kddejong @mmaeng @ericzbeard