Skip to content

[ru] Localize Ingress #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2024
Merged

[ru] Localize Ingress #3230

merged 2 commits into from
Aug 18, 2024

Conversation

kirkonru
Copy link
Collaborator

Describe your changes

Localize Ingress

Related issue number or link (ex: resolves #issue-number)

resolves #3122

Checklist before opening this PR (put x in the checkboxes)

  • This PR uses the dev-ru branch as a source/target.
  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@kirkonru kirkonru added the lang/ru for Russian label Jul 17, 2024
@kirkonru kirkonru added this to the [Russian] version 1 milestone Jul 17, 2024
@kirkonru kirkonru self-assigned this Jul 17, 2024
@kirkonru kirkonru requested review from shurup and tym83 as code owners July 17, 2024 08:00
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 2dff6a9
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/66b9ccac66131500080aa18a
😎 Deploy Preview https://deploy-preview-3230--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkonru kirkonru mentioned this pull request Jul 17, 2024
Closed
@kirkonru kirkonru linked an issue Jul 17, 2024 that may be closed by this pull request
[ru] Localize Ingress #3122
Closed
shurup
shurup reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another bunch of opinionated, small corrections from me — feel free to agree with them or not 😉

@kirkonru @shurup
[ru] Localize Ingress
6e564f0 
Signed-off-by: Kirill Kononovich <[email protected]>

Apply suggestions from code review

Co-authored-by: Dmitry Shurupov <[email protected]>
Signed-off-by: Kirill Kononovich <[email protected]>
@kirkonru kirkonru requested a review from shurup July 29, 2024 08:04
shurup
shurup approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@tym83
Update ingress.md
2dff6a9 
делают → осуществляют

Signed-off-by: Timur Tukaev <[email protected]>
@kirkonru kirkonru merged commit b6af100 into cncf:dev-ru Aug 18, 2024
5 checks passed
@kirkonru kirkonru deleted the localize_ingress branch August 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurup shurup shurup approved these changes

@tym83 tym83 tym83 approved these changes

Assignees

@kirkonru kirkonru

Labels
lang/ru for Russian
Projects
None yet
Milestone
[Russian] version 1
Development

Successfully merging this pull request may close these issues.

[ru] Localize Ingress
3 participants
@kirkonru @shurup @tym83