fix: updated auth for fetching user list #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghildiyal
reviewed
Aug 12, 2022
api/user/UserRestHandler.go
Outdated
| token := r.Header.Get("token") | ||
| isAuthorised := false | ||
| //checking for superadmin access | ||
| if ok := handler.enforcer.Enforce(token, casbin.ResourceGlobal, casbin.ActionGet, "*"); ok { |
There was a problem hiding this comment.
use userAuthService.IsSuperAdmin to check superadmin
pghildiyal
reviewed
Aug 12, 2022
api/user/UserRestHandler.go
Outdated
| } | ||
| for _, team := range teams { | ||
| //checking if user has manager access to atleast one team, if yes then the user is authorised | ||
| if ok := handler.enforcer.Enforce(token, casbin.ResourceUser, casbin.ActionDelete, strings.ToLower(team.Name)); ok { |
There was a problem hiding this comment.
use handler.enforcer.Enforce(token, casbin.ResourceUser, casbin.ActionGet, strings.ToLower(filter.Team))
…on into user-list-auth-change
pghildiyal
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auth is not present for fetching user list api. Added RBAC for the same api with only superadmins and manager to have access to the user list.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: