feat: Provide description for Chart Types #2585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -- Table Definition | ||
| CREATE TABLE "public"."chart_ref_metadata" ( | ||
| "chart_name" varchar(100) NOT NULL, | ||
| "chart_description" varchar(500) NOT NULL, |
There was a problem hiding this comment.
change type to text
| DROP TABLE "public"."chart_ref_metadata" CASCADE; | ||
|
|
||
| ----Rows Deletion--- | ||
| DELETE FROM "public"."chart_ref_metadata" WHERE ("chart_name"= 'Rollout Deployment') |
There was a problem hiding this comment.
remove delete statements. as this will throw error as you have dropped the table just above.
which means you didn't test this sql scripts :)
pkg/chart/ChartService.go
Outdated
| @@ -997,12 +1005,24 @@ func (impl ChartServiceImpl) ChartRefAutocomplete() ([]chartRef, error) { | |||
| func (impl ChartServiceImpl) ChartRefAutocompleteForAppOrEnv(appId int, envId int) (*chartRefResponse, error) { | |||
| chartRefResponse := &chartRefResponse{} | |||
| var chartRefs []chartRef | |||
| var chartRefMetadata chartRefMetaData | |||
There was a problem hiding this comment.
needs refactoring
manish-agrawal-ai
approved these changes
Nov 7, 2022
pawan-59
added a commit
that referenced
this pull request
Nov 9, 2022
* fixed migration query in 90th migration (#2586) * updated wiring for TelemetryEventClientExtended.go (#2588) * feat: Provide description for Chart Types (#2585) * chart description provided with the api call * added code to provide chart description with the api call * refined the code for poviding chart description * mitigated nil pointer exception in ChartService * refactoring * changes in sql files Co-authored-by: Manish Agrawal <[email protected]> * sql script semicolon fix (#2590) * Ci Build config API backward compatibilty (#2598) * docker build config added as backward compatible changes * dependency injection fix Co-authored-by: kartik-579 <[email protected]> Co-authored-by: Prakash Kumar <[email protected]> Co-authored-by: Manish Agrawal <[email protected]> Co-authored-by: kripanshdevtron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description for charts for all the chart type in the base deployment template (Cronjob and Job, Rollout Deployment, Knative and Deployment) within the same API call that fetches the chart types metadata when we click Base Deployment Template. So I introduced another field called 'chartMetadata' to that API response to avoid any data duplication where I will send the chart description metadata of only those charts which are currently provided by us with the same API call.
This is a new feature that will help frontend team build a new dashboard that will show chart type with chart description so that any user can select chart type according to their need.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?