Skip to content

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Nov 7, 2022

Description

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested with build

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@kartik-579 kartik-579 merged commit 8099445 into main Nov 7, 2022
@kartik-579 kartik-579 deleted the wiring-fix branch November 7, 2022 07:30
pawan-59 added a commit that referenced this pull request Nov 9, 2022
* fixed migration query in 90th migration (#2586)

* updated wiring for TelemetryEventClientExtended.go (#2588)

* feat: Provide description for Chart Types (#2585)

* chart description provided with the api call

* added code to provide chart description with the api call

* refined the code for poviding chart description

* mitigated nil pointer exception in ChartService

* refactoring

* changes in sql files

Co-authored-by: Manish Agrawal <[email protected]>

* sql script semicolon fix (#2590)

* Ci Build config API backward compatibilty (#2598)

* docker build config added as backward compatible changes

* dependency injection fix

Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Prakash Kumar <[email protected]>
Co-authored-by: Manish Agrawal <[email protected]>
Co-authored-by: kripanshdevtron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants