(Re)enable running tests from cli without specifying build infra #8688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, allow running the following
.\build.cmd -test -projects .\tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj
...instead of requiring /p:GITHUB_ACTIONS=true or /p:SYSTEM_TEAMPROJECT=foo
to indicate the test is run in GHA or AzDO.
github-actions
bot
added
the
area-engineering-systems
RussKie
commented
Apr 10, 2025
| @@ -57,6 +65,9 @@ | |||
|
|
|||
| <!-- Otherwise, run tests on AzDO CI agents --> | |||
| <SkipTests Condition=" '$(IsAzdoCIRunner)' == 'true' and '$(RunOnAzdoCI)' == 'true' ">false</SkipTests> | |||
|
|
|||
| <!-- If we're running locally, we don't skip tests --> | |||
| <SkipTests Condition=" '$(IsLocalDevLoop)' == 'true' ">false</SkipTests> | |||
There was a problem hiding this comment.
Locally we don't skip any tests (unless those were explicitly skipped).
For example, there are some tests which are declared as incompatible with Windows because there's no Docker on Windows build agents. Docker can be installed locally, meaning that such test can be run locally as well.
radical
approved these changes
Apr 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working in GHA for the past few weeks, I completely missed that running tests locally became impossible without passing an infra flag.
With this change it will now be possible to run tests again with just:
...instead of requiring
/p:GITHUB_ACTIONS=trueor/p:SYSTEM_TEAMPROJECT=footo indicate the test is run in GHA or AzDO.Before
After