Skip to content

(Re)enable running tests from cli without specifying build infra #8688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

(Re)enable running tests from cli without specifying build infra #8688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions eng/Testing.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,15 @@
<!-- See https://learn.microsoft.com/azure/devops/pipelines/build/variables#system-variables -->
<IsAzdoCIRunner Condition=" '$(SYSTEM_TEAMPROJECT)' != '' ">true</IsAzdoCIRunner>

<!-- See https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/Readme.md#common-helix-client-environment-variables -->
<IsHelix Condition=" '$(HELIX_CORRELATION_ID)' != '' ">true</IsHelix>

<IsAzdoHelixRunner Condition=" '$(PrepareForHelix)' == 'true' ">true</IsAzdoHelixRunner>

<!--
If we haven't detected the tests are run on build agents, then we presume we're running tests locally.
-->
<IsLocalDevLoop Condition=" '$(IsGitHubActionsRunner)' != 'true' and '$(IsAzdoCIRunner)' != 'true' and '$(IsHelix)' != 'true' and '$(IsAzdoHelixRunner)' != 'true' ">true</IsLocalDevLoop>
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -57,6 +65,9 @@

<!-- Otherwise, run tests on AzDO CI agents -->
<SkipTests Condition=" '$(IsAzdoCIRunner)' == 'true' and '$(RunOnAzdoCI)' == 'true' ">false</SkipTests>

<!-- If we're running locally, we don't skip tests -->
<SkipTests Condition=" '$(IsLocalDevLoop)' == 'true' ">false</SkipTests>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally we don't skip any tests (unless those were explicitly skipped).
For example, there are some tests which are declared as incompatible with Windows because there's no Docker on Windows build agents. Docker can be installed locally, meaning that such test can be run locally as well.

</PropertyGroup>

<ItemGroup Condition=" '$(IsTestProject)' == 'true' and '$(IncludeTestUtilities)' == 'true' ">
Expand Down
Loading