-
Notifications
You must be signed in to change notification settings - Fork 693
More URL fixes #8749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More URL fixes #8749
Conversation
if (string.IsNullOrEmpty(vm.DisplayName)) | ||
{ | ||
return @<span></span>; | ||
return @<span>-</span>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other places we have <span class="empty-data"></span>
and the dash is added by CSS. Change this to be consistent.
<span class="empty-data"></span> |
@davidfowl Didn't you make a purposeful change to only display http/https endpoints in the resource graph? |
Sounds familiar but I don't remember the details. It does occur to be now though that we probably need another value on the enum for where urls show up... |
Odd, I distinctly remember trying that. I must've made a change after that test. Will fix. |
@JamesNK fixed the filtering issue: Screen.Recording.2025-04-13.141214.mp4 |
Description
Fixes #8745
Fixes #8682
Checklist