Skip to content

Conversation

DamianEdwards
Copy link
Member

Description

  • Show "-" for URLs with no display text & disable visualizer
    image
  • Show non-HTTP endpoints on Resources Graph
    image

Fixes #8745
Fixes #8682

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

- Show "-" for URLs with no display text & disable visualizer & disable visualizer when URL has no display text (Fixes #8745)
- Show non-HTTP endpoints on Resources Graph (Fixes #8682)
if (string.IsNullOrEmpty(vm.DisplayName))
{
return @<span></span>;
return @<span>-</span>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places we have <span class="empty-data"></span> and the dash is added by CSS. Change this to be consistent.

<span class="empty-data"></span>

@JamesNK
Copy link
Member

JamesNK commented Apr 13, 2025

Show non-HTTP endpoints on Resources Graph

@davidfowl Didn't you make a purposeful change to only display http/https endpoints in the resource graph?

@JamesNK
Copy link
Member

JamesNK commented Apr 13, 2025

Text search doesn't include URLs based on their address, e.g. type in localhost or port number and the URL disappears

urls-port-search

@davidfowl
Copy link
Member

@davidfowl Didn't you make a purposeful change to only display http/https endpoints in the resource graph?

Sounds familiar but I don't remember the details. It does occur to be now though that we probably need another value on the enum for where urls show up...

@DamianEdwards
Copy link
Member Author

@JamesNK

Text search doesn't include URLs based on their address, e.g. type in localhost or port number and the URL disappears

Odd, I distinctly remember trying that. I must've made a change after that test. Will fix.

@DamianEdwards
Copy link
Member Author

@JamesNK fixed the filtering issue:

Screen.Recording.2025-04-13.141214.mp4

@DamianEdwards DamianEdwards requested a review from JamesNK April 13, 2025 21:38
@DamianEdwards DamianEdwards merged commit 9cbf38d into main Apr 13, 2025
174 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/UrlsFixes branch April 13, 2025 21:40
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard URL display bugs Resources with non-HTTP endpoints show as having "No endpoints" in dashboard graph view
4 participants