Skip to content

Conversation

AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from a team as code owners May 15, 2025 19:41
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels May 15, 2025
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 200)

matteo-prosperi and others added 7 commits May 15, 2025 15:12
* Editor configs for source packages

* Add nullable enable

* Include linked files in source packages

* Suppress RS1024

* Remove duplicate nullability directives

* Remove unnecessary extensions

* Move FatalError and FailFast to Contracts package

* Add disclaimer
Otherwise if we launch multiple processes, they might step atop
each other and cause locking issues.
Somehow almost every line started with a UTF-8 BOM. This fixes it.
Otherwise if we launch multiple processes, they might step atop each other and cause locking issues.
* Track used assemblies of data section string literals

* Move reporting to module

* Fix a failing test

* Improve test

* Add a comment
@jasonmalinowski jasonmalinowski removed the request for review from a team May 16, 2025 21:28
RikkiGibson and others added 10 commits May 16, 2025 21:55
Resolves dotnet#77233

Angle brackets can be used as html elements in markdown, and so
sometimes need to be escaped (there is no issue if we always escape
them).
Resolves dotnet/vscode-csharp#6767

I am open to other ideas on how to render the top level entry point. For
now I just used the display name, which should match what other places
like diagnostics may report. Potentially could not include it at all, or
name it something else?

In VSCode:

![image](https://github.com/user-attachments/assets/0106820e-c8bf-4921-9864-75ca040ebc47)

In VS, we only show max 2 levels, so the only change is that the top
level program entry point can be seen, instead of it being blank:

![image](https://github.com/user-attachments/assets/ccf24277-df54-4c5c-b7ef-cd13fb68bab1)
…ts.binaryLogPath"` throwing an exception (dotnet#78644)

Co-authored-by: Joey Robichaud <[email protected]>
@AlekseyTs AlekseyTs enabled auto-merge May 19, 2025 22:07
@AlekseyTs AlekseyTs merged commit 7628b7a into dotnet:features/extensions May 19, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Needs API Review Needs to be reviewed by the API review council VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.