Don't load the razor redirector unless it could actually be a razor assembly #79154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
Jun 26, 2025
| public string? RedirectPath(string fullPath) | ||
| { | ||
| // Simple heuristic so we don't load razor unnecessarily. | ||
| if (fullPath.IndexOf("razor", StringComparison.OrdinalIgnoreCase) >= 0) |
There was a problem hiding this comment.
Should you check for cshtml here as well?
If it's the path of a file in the loaded project, seems like 'yes'. If it's the path to a source generator, seems like 'no'.
There was a problem hiding this comment.
Path to source generator and related assemblies.
333fred
approved these changes
Jun 26, 2025
RikkiGibson
reviewed
Jun 26, 2025
src/Tools/ExternalAccess/Razor/Features/RazorAnalyzerAssemblyRedirector.cs
Show resolved
Hide resolved
RikkiGibson
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple heuristic so we don't load the razor redirector unless it could plausibly be a razor assembly.
This will give false positives, but that's fine. The actual razor redirector knows the specific assemblies to redirect.
All the razor assemblies have 'razor' in their name and live in a directory with 'razor' in their name, so we should never have false negatives from this.