Skip to content

Don't load the razor redirector unless it could actually be a razor assembly #79154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Don't load the razor redirector unless it could actually be a razor assembly #79154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9410653
Don't load the razor redirectory unless it could actually be a razor …
chsienki Jun 26, 2025
329a011
Use indexof instead of contains due to netstandard2.0
chsienki Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Tools/ExternalAccess/Razor/Features/RazorAnalyzerAssemblyRedirector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,17 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.Razor;
[Export(typeof(IAnalyzerAssemblyRedirector)), Shared]
[method: ImportingConstructor]
[method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)]
internal sealed class RazorAnalyzerAssemblyRedirector([Import(AllowDefault = true)] RazorAnalyzerAssemblyRedirector.IRazorAnalyzerAssemblyRedirector? razorRedirector = null) : IAnalyzerAssemblyRedirector
internal sealed class RazorAnalyzerAssemblyRedirector([Import(AllowDefault = true)] Lazy<RazorAnalyzerAssemblyRedirector.IRazorAnalyzerAssemblyRedirector>? razorRedirector) : IAnalyzerAssemblyRedirector
{
public string? RedirectPath(string fullPath) => razorRedirector?.RedirectPath(fullPath);
public string? RedirectPath(string fullPath)
{
// Simple heuristic so we don't load razor unnecessarily.
if (fullPath.IndexOf("razor", StringComparison.OrdinalIgnoreCase) >= 0)
Copy link
Member

@phil-allen-msft phil-allen-msft Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you check for cshtml here as well?

If it's the path of a file in the loaded project, seems like 'yes'. If it's the path to a source generator, seems like 'no'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path to source generator and related assemblies.

{
return razorRedirector?.Value.RedirectPath(fullPath);
}
return null;
}

internal interface IRazorAnalyzerAssemblyRedirector
{
Expand Down
Loading