Skip to content

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 7, 2025

Removes "allow partial updates" flag and the implementation of UpdateBaselinesAsync. The debugger has made the necessary changes.

@JoeRobich
Copy link
Member

Should this target main-vs-deps?

@tmat
Copy link
Member Author

tmat commented Jul 16, 2025

Should this target main-vs-deps?

I don't think that would work. We need to flow this change to dotnet-watch as well.
I don't want to have different bits between dotnet-watch and VS/VS Code.

Will sacrifice EnC integration tests for now. Since the debugger protocol is changing they would test legacy behavior that is not relevant anymore.
They should automatically disable themselves if the debugger contracts don't match.

@tmat tmat force-pushed the DebuggerContracts branch 2 times, most recently from 5676534 to 6b7af96 Compare July 20, 2025 16:48
@tmat
Copy link
Member Author

tmat commented Jul 21, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tmat tmat marked this pull request as ready for review July 21, 2025 15:59
@tmat tmat requested review from a team as code owners July 21, 2025 15:59
@tmat
Copy link
Member Author

tmat commented Jul 21, 2025

@DustinCampbell ptal

@tmat tmat force-pushed the DebuggerContracts branch from 6b7af96 to dd3b536 Compare July 24, 2025 00:19
@tmat
Copy link
Member Author

tmat commented Jul 24, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tmat tmat force-pushed the DebuggerContracts branch from dd3b536 to c5e67f1 Compare July 24, 2025 17:27
@tmat tmat enabled auto-merge (squash) July 24, 2025 17:37
@tmat tmat merged commit 6c7ade3 into dotnet:main Jul 24, 2025
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 24, 2025
@tmat tmat deleted the DebuggerContracts branch July 24, 2025 23:20
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 25, 2025
…rlier

* upstream/main: (217 commits)
  Fix tests
  Fix tests
  Fix tests
  Fix tests
  Fix tests
  Fix tests
  Reduce allocations during CommonCompletionItem.Create (dotnet#79591)
  Fix tests
  Fix tests
  Fix tests
  Fix tests
  Add test
  Fix tests
  Add work item
  Fix eol handling on the last token in a file when formatting code actions
  remove unchecked values from tests
  [main] Source code updates from dotnet/dotnet (dotnet#79599)
  Nullable extensions: Add assertion to AsMemberOfType and handle failures (dotnet#79428)
  Avoid adding dependency on System.Threading.Channels to InteractiveHost (dotnet#79594)
  Update debugger contracts to 18.0.0-beta.25353.1 (dotnet#79277)
  ...
dibarbet added a commit to dibarbet/roslyn that referenced this pull request Jul 25, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants