Reduce allocations during CommonCompletionItem.Create #79591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when looking at a ManagedLangsVS64.Typing test profile. CommonCompletionItem.Create accounts for about 1.4% of allocations in the test, about 1/3 of which is due to some linq usage. This change just expands that linq out and reduces the amount of data the method needs generated for it.
CyrusNajmabadi
approved these changes
Jul 25, 2025
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 25, 2025
…rlier * upstream/main: (217 commits) Fix tests Fix tests Fix tests Fix tests Fix tests Fix tests Reduce allocations during CommonCompletionItem.Create (dotnet#79591) Fix tests Fix tests Fix tests Fix tests Add test Fix tests Add work item Fix eol handling on the last token in a file when formatting code actions remove unchecked values from tests [main] Source code updates from dotnet/dotnet (dotnet#79599) Nullable extensions: Add assertion to AsMemberOfType and handle failures (dotnet#79428) Avoid adding dependency on System.Threading.Channels to InteractiveHost (dotnet#79594) Update debugger contracts to 18.0.0-beta.25353.1 (dotnet#79277) ...
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when looking at a ManagedLangsVS64.Typing test profile. CommonCompletionItem.Create accounts for about 1.4% of allocations in the test, about 1/3 of which is due to some linq usage. This change just expands that linq out and reduces the amount of data the method needs generated for it.