Skip to content

Update test command to use global.json #50673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 10, 2025
Merged

Update test command to use global.json #50673

merged 10 commits into from
Sep 10, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 8, 2025 •
edited
Loading

This PR removes support for dotnet.config and switches the runner/platform choice to global.json instead.

dotnet.config was a new configuration file in .NET 10 that we only used for dotnet.test.runner setting. It's available up to RC1 already (RC1 will ship with dotnet.config). This PR aims to remove dotnet.config starting with RC2. This is based on user feedback about dotnet.config

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/globaljson branch from 5674a05 to 3a63b10 Compare September 8, 2025 08:02
@Youssef1313 Youssef1313 mentioned this pull request Sep 8, 2025
Open
@Youssef1313 Youssef1313 marked this pull request as ready for review September 8, 2025 11:44
@Youssef1313 Youssef1313 requested a review from a team as a code owner September 8, 2025 11:44
This was referenced Sep 8, 2025
Merged
Closed
mariam-abdulla
mariam-abdulla reviewed Sep 8, 2025
View reviewed changes
Evangelink
Evangelink reviewed Sep 8, 2025
View reviewed changes
@Youssef1313 Youssef1313 marked this pull request as draft September 8, 2025 14:14
@Youssef1313
Copy link
Member Author

DRAFTING to avoid accidental merge for now.

This was referenced Sep 8, 2025
Draft
Draft
Draft
Draft
tkapin
tkapin reviewed Sep 8, 2025
View reviewed changes
Copy link
Member

@tkapin tkapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the new logic is tested. It can be done in a separate PR.

Also, please make sure that the PR is properly described.

This was referenced Sep 8, 2025
Open
Open
This was referenced Sep 8, 2025
Open
Open
@Youssef1313 Youssef1313 marked this pull request as ready for review September 10, 2025 17:50
@Youssef1313
Copy link
Member Author

The change is approved.

@Youssef1313 Youssef1313 enabled auto-merge (squash) September 10, 2025 17:50
@Youssef1313 Youssef1313 merged commit a219732 into release/10.0.1xx Sep 10, 2025
27 of 28 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/globaljson branch September 10, 2025 18:27
@tarunramsinghani tarunramsinghani mentioned this pull request Sep 11, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@tkapin tkapin tkapin left review comments

@mariam-abdulla mariam-abdulla mariam-abdulla approved these changes

@baronfel baronfel baronfel approved these changes

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

+1 more reviewer

@bradwilson bradwilson bradwilson left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area-dotnet test (MTP) Area-dotnet test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Youssef1313 @bradwilson @baronfel @Evangelink @tkapin @mariam-abdulla