-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adjust MTP detection #21302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Adjust MTP detection #21302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2f02ee
to
962a6c3
Compare
This change was manually tested using the following steps:
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Added error handling when parsing global.json for test runner.
Closing this PR as this is replaced with a local branch PR @ #21315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items
Depends on dotnet/sdk#50673
Task Name
DotNetCoreCLI
Description
In past, we added support for
dotnet.config
(this was shipped during .NET 10 previews, and will be shipped in RC1 as well).However, starting from RC2 (if the dotnet/sdk PR above is merged), we will be dropping dotnet.config completely, and switching to global.json. This PR updates the DotNetCoreCLI task to read global.json instead of dotnet.config.
Risk Assessment (Low / Medium / High)
Low. This is a .NET 10 feature that didn't yet ship in GA and has very low number of users.
Change Behind Feature Flag (Yes / No)
Can this change be behind feature flag, if not why?
There is already a feature flag in this code path.
Tech Design / Approach
Instead of parsing dotnet.config as TOML, we parse now global.json.
Documentation Changes Required (Yes/No)
Indicate whether related documentation needs to be updated.
Unit Tests Added or Updated (Yes / No)
Indicate whether unit tests were added or modified to reflect these changes.
Tested manually.
Additional Testing Performed
List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).
Tested manually.
Logging Added/Updated (Yes/No)
Debug logging is added.
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
No
Dependency Impact Assessed and Regression Tested (Yes/No)
Checklist